How to become a committer
In the PrestaShop project, committer are contributors with partial merge rights.
Committers participate in reviewing code contributions and are able to include them in the project once they have been accepted and verified.
Requirements to become a committer
- Active participation in the project
- Display a record of several accepted, quality Pull Requests having received little or no objections from maintainers.
- Display a record of Pull Request reviews.
- Be active in the project’s Slack chat.
- Real interest in getting involved.
- Demonstrate a good level of technical knowledge
- Justify a good level of technical skills (SOLID, readable, well-documented, stable, testable code) – in discussions and in code contributions.
- Display a good understanding of the project, its architecture, its ecosystem, its constraints (transparency, license, backwards compatibility, dependencies, expected behavior…)
- Be competent with git and the GitHub workflow (use a fork, be able to rebase, be able to fetch and update a remote branch…)
- Cultural convergence
- Respect the Code of Conduct; behave respectfully and in good faith.
- Agree to work together with the rest of the maintainer team towards main goals (see The Future Architecture): migration to Symfony, adoption of VueJS …
Requirements to continue being a committer
All the above, plus:
- Continuous participation and involvement
- Actively and responsibly review Pull Requests.
- Responsible behavior
- Respect & enforce the project’s quality standards and contribution guidelines.
- Respect & enforce the project’s issue and code review workflow.
- Respect & enforce convergence with the project’s goals.
- Put the best interest of the project before one’s own (in case of conflict of interests).
How to apply to be a committer
- Open an issue on the open source repository explaining why you apply to become a committer, and on what part of the project (Core or module/subproject).
- Discuss with current maintainers on this issue; particularly, this will be the time for maintainers to analyze the candidate’s motivation and skills on the different parts of the project that they applied for.
- Once all questions have been answered, current maintainers vote.
- If the simple majority of positive votes is achieved, the new committer is approved.
Upon approval, new committer is granted full committer rights and accesses for a 90-day trial period. This period aims to provide both the maintainer team and the new committer a better understanding of this new arrival and to validate whether expectations meet reality. Both maintainer team or new committer can express their wish for this situation to end before the 90-day trial period, revoking the committer status.
At the end of the 90-day trial period, the committer is confirmed in his position.
How to lose the committer status
A project committer status can be revoked for any of the following reasons:
- Refusal to follow the rules and policies stated in this document.
- Lack of activity for the past three months.
- Willful negligence or intent to harm the PrestaShop project.
- On their demand, for personal reasons.